Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeouts should let the benchmarker finish writing the csv #103

Open
jeffa5 opened this issue Oct 11, 2022 · 0 comments
Open

Timeouts should let the benchmarker finish writing the csv #103

jeffa5 opened this issue Oct 11, 2022 · 0 comments
Labels
benchmark Work on the benchmarking bug Something isn't working p2 Nice-to-have. Work we want to pick up at one point but not urgent or critical (ie, hardening work). S Less than 2 days

Comments

@jeffa5
Copy link
Collaborator

jeffa5 commented Oct 11, 2022

Describe the bug

When the benchmark run takes too long it gets a timeout and we kill the benchmarking process. This can be during the stage of writing results out to csv, leading to broken values.

Expected behavior

The csv data is intact, either a row is complete or not.
@jeffa5 jeffa5 added bug Something isn't working S Less than 2 days p2 Nice-to-have. Work we want to pick up at one point but not urgent or critical (ie, hardening work). benchmark Work on the benchmarking labels Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmark Work on the benchmarking bug Something isn't working p2 Nice-to-have. Work we want to pick up at one point but not urgent or critical (ie, hardening work). S Less than 2 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeffa5