Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move remaining SM 6.8 diagnostics to Sema and add test coverage #5990

Closed
hekota opened this issue Nov 8, 2023 · 0 comments · Fixed by #5992
Closed

Move remaining SM 6.8 diagnostics to Sema and add test coverage #5990

hekota opened this issue Nov 8, 2023 · 0 comments · Fixed by #5992
Assignees
@bob80905
Labels
bug Bug, regression, crash sm6.8 Shader Model 6.8 tech-debt
Milestone
Shader Model 6.8

Comments

@hekota
Copy link
Member

hekota commented Nov 8, 2023

Description
The following diagnostics should be moved from CodeGen to Sema and need to have tests added:

DirectXShaderCompiler/tools/clang/lib/CodeGen/CGHLSLMS.cpp

Line 1405 in d5ddb1e

static void ReportMissingNodeDiag(DiagnosticsEngine &Diags,

DirectXShaderCompiler/tools/clang/lib/CodeGen/CGHLSLMS.cpp

Line 1555 in d5ddb1e

"Ray function cannot be used as a global entry point");

DirectXShaderCompiler/tools/clang/lib/CodeGen/CGHLSLMS.cpp

Line 2519 in d5ddb1e

Diags.getCustomDiagID(DiagnosticsEngine::Error,

DirectXShaderCompiler/tools/clang/lib/CodeGen/CGHLSLMS.cpp

Line 2680 in d5ddb1e

"NodeTrackRWInputSharing attribute cannot be applied to "

For more context see discussion about tools/clang/lib/CodeGen/CGHLSLMS.cpp in PR #5982.
@hekota hekota added bug Bug, regression, crash needs-triage Awaiting triage labels Nov 8, 2023
@hekota hekota mentioned this issue Nov 8, 2023
Merged
@bob80905 bob80905 mentioned this issue Nov 9, 2023
Merged
@llvm-beanz llvm-beanz added tech-debt sm6.8 Shader Model 6.8 and removed needs-triage Awaiting triage labels Nov 9, 2023
@llvm-beanz llvm-beanz added this to the Shader Model 6.8 milestone Nov 9, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in HLSL Roadmap Nov 9, 2023
@llvm-beanz llvm-beanz moved this to Done in HLSL Triage Nov 9, 2023
@llvm-beanz llvm-beanz moved this from 🆕 New to 📋 Backlog in HLSL Roadmap Nov 9, 2023
@bob80905 bob80905 moved this from 📋 Backlog to 👀 In review in HLSL Roadmap Nov 13, 2023
@bob80905 bob80905 self-assigned this Nov 13, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in HLSL Roadmap Nov 20, 2023
cassiebeckley pushed a commit to cassiebeckley/DirectXShaderCompiler that referenced this issue Nov 21, 2023
@bob80905 @llvm-beanz
[Sema] Move more diagnostics over (microsoft#5992)
dc7a595 
This PR moves over some more diagnostics from CGHLSLMS.cpp. Some
diagnostics are moved into DiagnoseEntryAttrAllowedOnStage, to
specifically diagnose when an attribute appears on a shader stage that
it shouldn't appear on. Other diagnostics that are covered in Sema are
removed in CGHLSLMS.
Fixes microsoft#5990

---------

Co-authored-by: Chris B <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bob80905 bob80905

Labels
bug Bug, regression, crash sm6.8 Shader Model 6.8 tech-debt
Projects
HLSL Roadmap
Archived in project
HLSL Triage
Archived in project
Milestone
Shader Model 6.8
Development

Successfully merging a pull request may close this issue.

[Sema] Move more diagnostics over bob80905/DirectXShaderCompiler
3 participants
@llvm-beanz @hekota @bob80905