Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a historical::adapter_v4 which allows customisation of the response for every error category #5241

Closed
eddyashton opened this issue May 5, 2023 · 1 comment · Fixed by #6322
Assignees
Milestone

Comments

@eddyashton
Copy link
Member

eddyashton commented May 5, 2023

The current historical adapter (v3) is inconsistent in whether the callbacks set response bodies (app controlled format), or whether the adapter does itself (our error format + contents). Specifically, we dictate the error format when transactions are not currently available, and when historical service endorsements are not currently available.

To make the adapter more usefully generic, we should remove any calls to ctx->set in its body, and defer all of that to app-controlled callbacks. This will let applications use the adapter, while fully controlling their API surface.

@eddyashton eddyashton added the TODO label May 5, 2023
@eddyashton eddyashton changed the title Make a historical::adapter_v4 which allows full customisation of the response Make a historical::adapter_v4 which allows customisation of the response for every error category May 5, 2023
@maxtropets maxtropets self-assigned this Jun 17, 2024
@achamayou achamayou added this to the 5.x milestone Jul 1, 2024
@maxtropets
Copy link
Collaborator

Closed in #6322 6322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants