You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current historical adapter (v3) is inconsistent in whether the callbacks set response bodies (app controlled format), or whether the adapter does itself (our error format + contents). Specifically, we dictate the error format when transactions are not currently available, and when historical service endorsements are not currently available.
To make the adapter more usefully generic, we should remove any calls to ctx->set in its body, and defer all of that to app-controlled callbacks. This will let applications use the adapter, while fully controlling their API surface.
The text was updated successfully, but these errors were encountered:
eddyashton
changed the title
Make a historical::adapter_v4 which allows full customisation of the response
Make a historical::adapter_v4 which allows customisation of the response for every error category
May 5, 2023
The current historical adapter (v3) is inconsistent in whether the callbacks set response bodies (app controlled format), or whether the adapter does itself (our error format + contents). Specifically, we dictate the error format when transactions are not currently available, and when historical service endorsements are not currently available.
To make the adapter more usefully generic, we should remove any calls to
ctx->set
in its body, and defer all of that to app-controlled callbacks. This will let applications use the adapter, while fully controlling their API surface.The text was updated successfully, but these errors were encountered: