Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics should be moved out of EndpointRegistry, and managed as a SubSystem #4207

Closed
eddyashton opened this issue Sep 9, 2022 · 3 comments
Closed
Assignees

Comments

@eddyashton
Copy link
Member

eddyashton commented Sep 9, 2022

The per-endpoint metrics (number of calls, error, retries) has been a weird bridge between the Frontend and the EndpointRegistry for a while - primarily owned and updated by the Frontend, but available for the EndpointRegistry to call. It currently lives on the EndpointRegistry, meaning its implementation is visible to all apps, and they could even call increment_metrics_*. We have a better way to own + expose things like this now - as a subsystem. I think this should even be a private subsystem, as the only use case we have for exposing individual metrics is in the node_frontend.

@achamayou
Copy link
Member

@eddyashton I think we need to revisit whether metrics are worth keeping or not, now that we are going to log per-endpoint. @lynshi what do you think?

@achamayou
Copy link
Member

achamayou commented Jun 11, 2024

  • Check endpoint logging is comprehensive enough, and if so, remove /api/metrics now that users have confirmed that it is unused.

@eddyashton
Copy link
Member Author

Resolved by #6283.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants