Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous API models/dto/contracts #486

Open
bleepzter opened this issue May 16, 2023 · 0 comments
Open

Ambiguous API models/dto/contracts #486

bleepzter opened this issue May 16, 2023 · 0 comments

Comments

@bleepzter
Copy link

  • There are several instances where API Models contain domain models when they shouldn't.
  • No clear conversion between API models and domain models.
  • Update function takes a ShortUrlEntity which inherits from TableEntity. Its hard to know what we need to send to the function without bringing in the storage SDK so that we can fill in the fields that are described by TableEntity.
  • Create function returns a descriptor and not the actual etag ShortUrlEntity. If you want to update a ShortUrlEntity you have to first find it with the List function and then update it afterwards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant