Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove neo4j-harness from neo4j feature for Micronaut 5 #2390

Open
wetted opened this issue Mar 7, 2024 · 3 comments · May be fixed by #2434
Open

Remove neo4j-harness from neo4j feature for Micronaut 5 #2390

wetted opened this issue Mar 7, 2024 · 3 comments · May be fixed by #2434

Comments

@wetted
Copy link
Contributor

wetted commented Mar 7, 2024

The Neo4J module removes the test harness in Micronaut 5, in favor of using Testcontainers Neo4J. Remove that test-harness dependency from the Neo4JBolt feature.
@wetted wetted self-assigned this Mar 7, 2024
@sdelamo sdelamo moved this to Del Deprecated in 5.0.0 Release Mar 20, 2024
@wetted
Copy link
Contributor Author

wetted commented Apr 2, 2024

see micronaut-projects/micronaut-neo4j#422

wetted added a commit that referenced this issue Apr 10, 2024
@wetted
Remove obsolete neo4j test harness dependency in favor of Testcontain…
b13bbf6 
…ers Neo4j. Support for the former was removed from micronaut-neo4j for Micronaut Framework 5. [skip ci]

closes #2390
@wetted wetted linked a pull request Apr 10, 2024 that will close this issue
Open
@wetted wetted linked a pull request Apr 10, 2024 that will close this issue
Remove obsolete neo4j test harness dependency in favor of Testcontainers Neo4j #2434
Open
@wetted wetted moved this from Del Deprecated to In Progress in 5.0.0 Release Apr 11, 2024
@sdelamo
Copy link
Contributor

sdelamo commented Apr 19, 2024

can this be closed?

@wetted
Copy link
Contributor Author

wetted commented Apr 19, 2024

can this be closed?

I still have a little work to do on the PR. I will finish that next week.

@wetted wetted moved this from In Progress to Ready for review in 5.0.0 Release Apr 22, 2024
@wetted wetted removed their assignment Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
5.0.0 Release
Status: Ready for review
Milestone
No milestone
2 participants
@sdelamo @wetted