Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes gradle scripts #215

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

altro3
Copy link
Contributor

@altro3 altro3 commented Dec 28, 2024

Gradle 8.12
Update libs

Fixed tests for windows

Gradle 8.12
Update libs

Fixed tests for windows
@graemerocher graemerocher merged commit a663672 into micronaut-projects:1.5.x Jan 8, 2025
6 checks passed
@sdelamo
Copy link
Contributor

sdelamo commented Jan 10, 2025

@graemerocher @altro3 I think this broke the published artifacts #221

@sdelamo
Copy link
Contributor

sdelamo commented Jan 10, 2025

moreover, it would be good not to change the project structure. We use buildSrc in every repo. This PR changes to use build-logic. We have so many repositories that if the structure is different in every repo it is a nightmare to maintain.


micronautBuild {
binaryCompatibility {
enabled.set(false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we disabling binary compatibility?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdelamo don't know, that's not my code. I didn't change this file, just move it to build-logic

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be always disable for a new project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants