Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace micromatch github dependency #23

Open
ghost opened this issue Dec 8, 2017 · 7 comments · May be fixed by #37
Open

Replace micromatch github dependency #23

ghost opened this issue Dec 8, 2017 · 7 comments · May be fixed by #37

Comments

@ghost
Copy link

ghost commented Dec 8, 2017

Could you please replace the micromatch github- by a npm-dependency?
This leads to trouble by firewall restrictions or deployments through inhouse npm caches. Thx!

@jonschlinkert
Copy link
Member

want to do a pr?

@henninga
Copy link

I could do a pr but all of the tests fails on my machine right after npm install

@marlonmarcello
Copy link

@jonschlinkert I have the same issue as @henninga
This breaks CI/CD on Amplify and others.

@jonschlinkert
Copy link
Member

yes, sure. want to do a PR? sorry for the lack of activity, I'll be spending a lot more time on GitHub going forward.

thanks!

@marlonmarcello
Copy link

All good @jonschlinkert ! Appreciate everything that you've done.
I can't do a PR for the same reason that @henninga can't. I get a bunch of test fails.

@jonschlinkert
Copy link
Member

I can't do a PR for the same reason that @henninga can't. I get a bunch of test fails.

Well... lol someone will need to get those tests passing. I'd appreciate a PR from someone, but I can do it when I get a chance.

@patcon patcon linked a pull request Jan 8, 2022 that will close this issue
@rbitting
Copy link

rbitting commented Apr 15, 2022

Any update on this? I'm encountering the same issue. FWIW it doesn't seem like the unit tests pass with the current micromatch github package either 😅

Edit: Workaround until this is fixed is to just add a resolution for micromatch in the package.json. Example:

"resolutions": {
    "micromatch": "^4.0.2"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants