We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I have a problem reading the cookie via your provided functions. I identified the root problem to be the hashing of cookies in Kirby. The CookieBanner::getCookie returns null because Cookie::get returns null. This is due to the early access in https://github.com/getkirby/kirby/blob/6b7ac66c55ecac20d6b580ef01a667d1806d5c72/src/Http/Cookie.php#L143
CookieBanner::getCookie
Cookie::get
The text was updated successfully, but these errors were encountered:
Fix isFeatureAllowed string comparison
63da97f
This fixes michnhokn#20. This also should fix michnhokn#19. The [`str_contains` function works vice-versa](https://www.php.net/manual/en/function.str-contains.php) than implemented before. In a local test environment this fixed the issues above and worked fine again.
For completeness, here’s a local workaround for those who need it:
private static function getCookie(): ?string { $cookie = $_COOKIE[self::COOKIE_NAME] ?? null; if (!is_string($cookie) or empty($cookie)) { return null; } return $cookie; }
Sorry, something went wrong.
No branches or pull requests
I have a problem reading the cookie via your provided functions. I identified the root problem to be the hashing of cookies in Kirby. The
CookieBanner::getCookie
returns null becauseCookie::get
returns null.This is due to the early access in https://github.com/getkirby/kirby/blob/6b7ac66c55ecac20d6b580ef01a667d1806d5c72/src/Http/Cookie.php#L143
The text was updated successfully, but these errors were encountered: