Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add @dit-throw to ignore error #105

Closed
khuezy opened this issue Dec 28, 2023 · 4 comments
Closed

Feature Request: Add @dit-throw to ignore error #105

khuezy opened this issue Dec 28, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@khuezy
Copy link

khuezy commented Dec 28, 2023

Use case: Some workflows are expected to throw, eg a temporal workflow that aborts on a thrown error.

//@dit-ignore (or equivalent) should tell DIT to ignore the throw statement.

Why: I don't want DIT to give me the squigglies when I expect a function to throw.

@michaelangeloio
Copy link
Owner

michaelangeloio commented Jan 1, 2024

@khuezy do we prefer // @dit-ignore or // @does-it-throw-ignore, or both?

@khuezy
Copy link
Author

khuezy commented Jan 1, 2024

@michaelangeloio or maybe @throw-ignore? I'm fine with whatever is best.

@michaelangeloio michaelangeloio added the enhancement New feature or request label Jan 1, 2024
@khuezy
Copy link
Author

khuezy commented Jan 3, 2024

@michaelangeloio Can the @ flag be configurable? I kinda like // @it-throws as an answer to does-it-throw.

@michaelangeloio
Copy link
Owner

#118 closes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants