-
Notifications
You must be signed in to change notification settings - Fork 0
/
bugs.txt
207 lines (121 loc) · 8.15 KB
/
bugs.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
.gitignore
Didn't have a single blank line at the end of the file
IndividualProject/pom.xml
Indentation was incorrect
IndividualProject/src/main/java/dev/coms4156/project/individualproject/Course.java
1. enrollStudent() always returned false - updated to check to see if course is full first
2. toString() was missing the @Override annotation (PMD Rule: MissingOverride)
3. Missing JavaDoc for class (CheckStyle Rule: CommentRequired)
4. Fixed wildcard import statements (CheckStyle Rule: AvoidStarImport)
5. Reformatted all JavaDocs using Google Java code style rules
6. isCourseFull() logic was backwards! Updated to be functional.
7. The enrolledStudentCount class variable should be 0 instead of 500.
IndividualProject/src/main/java/dev/coms4156/project/individualproject/Department.java
1. Missing @Override statement on toString() (PMD Rule: MissingOverride)
2. getDepartmentChair() did not return value of class variable
3. getCourseSelection() had return type of HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
4. Department() arguments used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
5. toString() failed to return result.toString()
6. courses class variable used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
7. courses class variable changed to be final (CheckStyle Rule: FinalLocalVariable)
8. departmentChair class variable changed to be final (CheckStyle Rule: FinalLocalVariable)
9. deptCode class variable changed to be final (CheckStyle Rule: FinalLocalVariable)
10. Fixed wildcard import statements (CheckStyle Rule: AvoidStarImport)
11. Reformatted all JavaDocs using Google Java code style rules
12. Reformatted constructor to abide by Google Java code style rules
13. getNumberOfMajors() had an erroneous minus sign in it!
14. dropPersonFromMajor() needed to check if the number of majors is positive
15. Reformatted createCourse() parameters to abide by Google Java code style rules
16. Reformatted toString() to abide by Google Java code style rules.
IndividualProject/src/main/java/dev/coms4156/project/individualproject/IndividualProjectApplication.java
1. Indentation fixed on file using Google Java code style rules
2. Fixed wildcard import statements (CheckStyle Rule: AvoidStarImport)
3. Reformatted all JavaDocs using Google Java code style rules
4. Added "<p>" to class JavaDoc. (CheckStyle Rule: JavadocParagraph)
IndividualProject/src/main/java/dev/coms4156/project/individualproject/MyFileDatabase.java
1. Fixed wildcard import statements (CheckStyle Rule: AvoidStarImport)
2. setMapping() parameter "mapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
3. deSerializeObjectFromFile() return type used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
3. deSerializeObjectFromFile() variable "obj" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
4. deSerializeObjectFromFile() returned null instead of empty collection
(PMD Rule: ReturnEmptyCollectionRatherThanNull)
5. getDepartmentMapping() return type used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
6. filepath class variable changed to be final (CheckStyle Rule: FinalLocalVariable)
7. departmentMapping class variable used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
8. Reformatted all JavaDocs using Google Java code style rules
IndividualProject/src/main/java/dev/coms4156/project/individualproject/RouteController.java
1. Fixed wildcard import statements (CheckStyle Rule: AvoidStarImport)
2. Use text block instead of concatenated strings. (IntelliJ suggestion)
3. Updated all annotations that used 'value = ' when it was the only argument in
the annotation. (PMD Rule: UnnecessaryAnnotationValueElement)
4. retrieveDepartment() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
5. Added "Locale.ENGLISH" when using toUpperCase on deptCode variable in retrieveDepartment()
(PMD Rule: UseLocaleWithCaseConversions)
6. Instead of returning HttpStatus.OK, we should return HttpStatus.NOT_FOUND
when the department is not found in retrieveDepartment()
7. Instead of returning HttpStatus.NOT_FOUND, we should return HttpStatus.OK when
the department is found in retrieveDepartment()
8. Reformatted all JavaDocs using Google Java code style rules
9. retrieveCourse() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
10. retrieveCourse() variable "coursesMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
11. Instead of returning HttpStatus.FORBIDDEN, we should return HttpStatus.OK
when the course is found in retrieveCourse().
12. isCourseFull() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
13. isCourseFull() variable "coursesMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
14. getMajorCtFromDept() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
15. getMajorCtFromDept() should return HttpStatus.NOT_FOUND when
department cannot be found.
14. identifyDeptChair() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
15. findCourseLocation() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
16. findCourseLocation() variable "coursesMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
17. findCourseLocation() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
18. findCourseLocation() variable "coursesMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
19. findCourseTime() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
20. findCourseTime() variable "coursesMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
21. addMajorToDept() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
22. removeMajorFromDept() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
23. dropStudent() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
24. dropStudent() variable "coursesMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
25. Added missing JavaDoc to setEnrollmentCount() (CheckStyle Rule: MissingJavadocMethod)
26. setEnrollmentCount() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
27. setEnrollmentCount() variable "coursesMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
28. changeCourseTime() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
29. changeCourseTime() variable "coursesMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
30. changeCourseTeacher() variable "departmentMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
31. changeCourseTeacher() variable "coursesMapping" used HashMap (implementation)
instead of Map (interface) (PMD Rule: LooseCoupling)
25. Added missing JavaDoc to changeCourseLocation() (CheckStyle Rule: MissingJavadocMethod)
26. Added missing blank line to the end of file
27. Remove erroneous minus sign from getMajorCtFromDepartment.
IndividualProject/src/test/java/dev/coms4156/project/individualproject/CourseUnitTests.java
1. Added missing JavaDoc to class (CheckStyle Rule: MissingJavadocMethod)