Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for response with both errors and data #70

Open
potasiyam opened this issue Dec 5, 2021 · 1 comment · May be fixed by #71
Open

Support for response with both errors and data #70

potasiyam opened this issue Dec 5, 2021 · 1 comment · May be fixed by #71

Comments

@potasiyam
Copy link

According to spec (http://spec.graphql.org/October2021/#sec-Errors.Error-result-format), GraphQL response can contain both errors and data at the same time. With current implementation this package throws the QueryError exception which only contains the first error details. So, right now there is no way to access the data that came with the error response.
The constructor of QueryError exception requires the full response. So may be we can have a property in this exception that will contain data?
@potasiyam potasiyam linked a pull request Dec 18, 2021 that will close this issue
Open
@potasiyam
Copy link
Author

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added data and errors in QueryError exception potasiyam/php-graphql-client
1 participant
@potasiyam