Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fimex creates files with corrupt data without error code #23

Open
heikoklein opened this issue Sep 2, 2020 · 0 comments
Open

fimex creates files with corrupt data without error code #23

heikoklein opened this issue Sep 2, 2020 · 0 comments

Comments

@heikoklein
Copy link
Member

Hi,
the newest fimex version create netcdf-files with corrupt data without error-code:

e.g.
fimex --extract.selectVariables WDEP_SOX 'https://thredds.met.no/thredds/dodsC/data/EMEP/2019_trends_EEA/EMEP01_L20EC_rv4_33_day.met2016_emis2017.nc' out.nc4
WARN: formula term 'ps' specifies unknown variable 'PS' in /build/fimex-1.5-1.5.0/src/coordSys/CF1_xCoordSysBuilder.cc at line 472
WARN: formula term 'ps' specifies unknown variable 'PS' in /build/fimex-1.5-1.5.0/src/coordSys/CF1_xCoordSysBuilder.cc at line 472
curl error details:
ERROR: exception while reading variable 'WDEP_SOX' at unlimited dim position 75; using _FillValue; message: CDMException: NetCDF: I/O failure in /build/fimex-1.5-1.5.0/src/NetCDF_CDMWriter.cc at line 718

In this case, a network error lead to an undelivered data request. fimex just writes the output and exits with code 0.

In an operational context, error output is not read unless the program fails, e.g. has a non-zero exit code.

This problem was introduced in 2ce00fb.

Fimex should give a non-zero exit code when errors occur. Fimex should not continue operations (unless explicitly requested) after an error occured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant