-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lutaml-express-index
command specs
#85
Comments
I need the dependency on metanorma removed, and the spec files need to be moved to metanorma-standoc, to remove the circular dependency in this gem. I have no idea how this gem works, and I have spent two hours trying to work it out. So: In spec/spec_helper.rb, you are to replace metanorma_process.rb with:
and remove the dependency on the metanorma gem. Once you have got the specs working, those specs with depend on metanorma-standoc to run (anything involving metanorma_process) need to be migrated to the metanorma-standoc gem, so that this gem no longer has a dependency on metanorma-standoc. (metanorma-standoc already depends on this gem.) When you do this, I will require spec/fixtures to be migrated to spec/fixtures/lutaml, rather than mixing it in with the existing files of metanorma-standoc spec/fixtures. You will also need to rewrite any spec/fixtures paths to spec/fixtures/lutaml in the test files. I have uploaded where I got to as the PR "migrate": #90 |
This issue indeed needs to be fixed. The PR to fix this is #91, please have the fixes implemented there. Thanks. |
The remaining specs are really broken, they are due to the
lutaml-express-index
command not working.Originally posted by @ronaldtse in #84 (comment)
The text was updated successfully, but these errors were encountered: