Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add more links to ignore file #529

Open
wants to merge 1 commit into
base: source
Choose a base branch
from

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Nov 25, 2024

Link checker is giving some false positives. I suggest we add links to ignore file to avoid these false positives.

Fixes

Fixes: #527
Fixes: #528

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 25, 2024
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for metal3io-website ready!

Name Link
🔨 Latest commit 2b898f2
🔍 Latest deploy log https://app.netlify.com/sites/metal3io-website/deploys/67444424fc2d710008b4d992
😎 Deploy Preview https://deploy-preview-529--metal3io-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/add-links-to-ignore branch from 28c9b65 to 2b898f2 Compare November 25, 2024 09:32
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2024
@tuminoid
Copy link
Member

To get issues marked as solved and auto close, use syntax:

Fixes: #number
Fixes: #another

It does not understand your nicely formatted summary :)

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smoshiur1237
Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
4 participants