Add option "ignorenamespace" #575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting "ignorenamespace" to "true" ignores checking the namespace.
blackwinter
requested changes
Nov 21, 2024
Comment on lines
+81
to
+82
| if (ignoreNamespace) { | ||
| this.namespace = null; |
There was a problem hiding this comment.
I don't think this is sufficient:
- It becomes order-dependent; if one sets
ignoreNamespacefirst and thennamespace, the namespace check is still performed. - One can't reenable the namespace check without also setting the namespace to its previous value.
You would need to introduce a dedicated attribute for this.
|
|
||
| verifyNoMoreInteractions(receiver); | ||
| } | ||
| @Test |
| @@ -146,6 +146,63 @@ public void issue330ShouldOptionallyRecognizeRecordsWithoutNamespace() | |||
| verifyNoMoreInteractions(receiver); | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldRecognizeRecordsWithoutNamespace() | |||
| throws SAXException { | |||
There was a problem hiding this comment.
Wrong indentation for all throws qualifiers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting "ignorenamespace" to "true" ignores checking the namespace.
Resolves #569.