Add WWW:DOWNLOAD-1.0-http--download #370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds as downloadable and can be hidden based on permissions. Also moved HTTPS to the top selection box default to first selection and most urls are HTTPS
josegar74
reviewed
Feb 14, 2024
There was a problem hiding this comment.
@ianwallen, it looks fine to me to add a specific value for downloads, but maybe we need to check the value with HNAP maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WWW:DOWNLOAD-1.0-http--download for the ability to identify records as downloadable and can be hidden based on permissions.
Also moved HTTPS to the top selection box default to first selection and most urls are HTTPS