Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY projects of different types #16

Open
pcowgill opened this issue Oct 3, 2019 · 1 comment
Open

DRY projects of different types #16

pcowgill opened this issue Oct 3, 2019 · 1 comment

Comments

@pcowgill
Copy link
Collaborator

pcowgill commented Oct 3, 2019

No description provided.

@pcowgill
Copy link
Collaborator Author

It's a little awkward that there are separate components for handling routes like /applications/:applicationId and /infrastructure/:infrastructureId given that they both just pass a param of project type to the Project component, or /applications and /infrastructure given that they both just pass a param of projects type to the Projects component.

That conditional logic could just happen in a single component.

But the awkward part about DRYing this up would be that we want /applications and /infrastructure to render Projects components, but not /some-other-path.

So for now any changes here are on hold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant