Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login credentials #4

Open
MarcusWolschon opened this issue Oct 4, 2016 · 4 comments
Open

login credentials #4

MarcusWolschon opened this issue Oct 4, 2016 · 4 comments

Comments

@MarcusWolschon
Copy link

MarcusWolschon commented Oct 4, 2016

You seem to just use the username and password of the mail account in
https://github.com/messagerie-melanie2/Roundcube-Plugin-Roundrive/blob/master/lib/roundrive_files_engine.php#L67

This should either be a setting for the user in the roundcube UI or at least documented in readme.md

@tpayen
Copy link
Member

tpayen commented Dec 14, 2016

Roundcube isn't made to store credentials informations in settings. This would be a major security flaw

@MarcusWolschon
Copy link
Author

Then obviously this fact must be clearly documented in the readme.md
Few, if any users will use the same username and the same password on their Mail account on host A and on their file storage on host B. Both reachable from the Internet.
On the contrary, even if they have the same username they are strongly discouraged not to use the same password for multiple services.

@mckaygerhard
Copy link

mckaygerhard commented Feb 17, 2017

well , "normal" users dont like has "many passwords" so this my require "more code" to made it! like RC-plugin does for OC, theres' and config option to use autologin credentials or not! maybe that's the idea, but i repeat, normal users like "auto"-all

other way its to parse encripted! but this are already made if used https! so i dont see the "encourage" here too much!

@MarcusWolschon
Copy link
Author

Since I can't get it to work even after creating a test-account with the email-adress used on the mail server instead of a user-name and the same password, I couldn't write that code and made a merge request, even if I knew where to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants