Support URL CEL library #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikachu0310
force-pushed
the
net-url
branch
from
2d15b60 to
030f536
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
shuheiktgw
reviewed
Sep 27, 2024
pikachu0310
force-pushed
the
net-url
branch
from
e811a9d to
a524494
Compare
This comment has been minimized.
This comment has been minimized.
|
I have addressed ktgw's review comments and resolved the conflicts. Please review it again. |
shuheiktgw
reviewed
Oct 1, 2024
This comment has been minimized.
This comment has been minimized.
utahta
reviewed
Oct 1, 2024
also lib.refToGoUserinfoValue
Code Metrics Report
Details | | main (e478944) | #244 (4e0c688) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 66.0% | 66.3% | +0.3% |
| Files | 75 | 76 | +1 |
| Lines | 12418 | 12557 | +139 |
+ | Covered | 8192 | 8320 | +128 |
+ | Code to Test Ratio | 1:0.4 | 1:0.4 | +0.0 |
| Code | 38524 | 39019 | +495 |
+ | Test | 13878 | 14665 | +787 |
+ | Test Execution Time | 7m55s | 7m45s | -10s |Code coverage of files in pull request scope (100.0% → 93.0%)
Reported by octocov |
pikachu0310
added a commit
that referenced
this pull request
Oct 4, 2024
Support strconv CEL library #244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide functionalities similar to Go's net/url using the grpc.federation.url library.