Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track failed published messages #198

Open
antoniobusrod opened this issue Mar 25, 2021 · 1 comment
Open

Track failed published messages #198

antoniobusrod opened this issue Mar 25, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@antoniobusrod
Copy link
Contributor

It would be nice to track the exceptions which happen when it is not possible to publish a message, for example, when there is a connectivity problem.

At the moment, there is the post_publish_failure middleware which is called when there is a timeout error (google.cloud.pubsub_v1.exceptions.TimeoutError, but it would not be called for any other error like google.api_core.exceptions.RetryError.

It would be nice to consider the possibility to track these messages through the existing post_publish_failure middleware or new middleware.

@andrewgy8 andrewgy8 added the enhancement New feature or request label Mar 25, 2021
@andrewgy8
Copy link
Contributor

Sounds like a great idea @antoniobusrod ! To take some inspiration from others, we can look at the way Dramatiq handles this here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants