Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc fixes for Ecowitt WS90 #2585

Merged
merged 6 commits into from
Aug 3, 2023
Merged

misc fixes for Ecowitt WS90 #2585

merged 6 commits into from
Aug 3, 2023

Conversation

jktjkt
Copy link
Contributor

@jktjkt jktjkt commented Aug 2, 2023

Thanks a lot for an excellent SDR SW, and to @jpochmara for this driver. Just some minor cleanups.

WS90: docs: fix an error in field description

The elementary unit is 10 lux, not 10'000 lux. The expressoin and the reported value are correct, just the English text was wrong.

Fixes: f8489e9 Add support for Fineoffset WS90 (#2448)

WS90: include correct bytes in the "extra-data" field

This got garbled in the commit which added FW version discovery.

Fixes: c94ee77 Change Fineoffset-WS90 to add firmware version (#2517)

WS90: put all unknown fields into a single extra-data blob

Let's get rid of the "unknown" field which is only conditionally returned, and instead put that data into "Extra Data".

The buffer size was arbitrary, but sufficient. This change makes the buffer exactly sized for all the unknown data and the trailing \0.

WS90: don't report supercapacitor voltage through "Extra Data"

b17 is already used for the supercapacitor voltage, so let's use a visual placeholder instead of just dumping that field.

WS90: mask out the known rain sensor data in "Extra Data"

The elementary unit is 10 lux, not 10'000 lux. The expressoin and the
reported value are correct, just the English text was wrong.

Fixes: f8489e9 Add support for Fineoffset WS90 (merbanan#2448)
This got garbled in the commit which added FW version discovery.

Fixes: c94ee77 Change Fineoffset-WS90 to add firmware version (merbanan#2517)
Let's get rid of the "unknown" field which is only conditionally
returned, and instead put that data into "Extra Data".

The buffer size was arbitrary, but sufficient. This change makes the
buffer exactly sized for all the unknown data and the trailing \0.
b17 is already used for the supercapacitor voltage, so let's use a
visual placeholder instead of just dumping that field.
@zuckschwerdt
Copy link
Collaborator

Thanks! Can you check if the "unknown" field is 0x3fff in normal conditions for you? Maybe document that finding if so.

@jktjkt
Copy link
Contributor Author

jktjkt commented Aug 3, 2023

Thanks! Can you check if the "unknown" field is 0x3fff in normal conditions for you? Maybe document that finding if so.

Yup, I haven't seen any different value so far.

For me, the extra data right now are 3fffa0a8d9------8c0bffaffa0000. That first part slowly changed from 3fff20a8d9 over night to the current 3fffa0a8d9, so it could be either some 16bit LE rain sensor data, or something related to the solar cell. I do not see a pattern (yet) for the other fields.

Pushed an update for these two fixed bytes. The rest might follow if I see something useful. It's a shiny toy, both the HW, the SDR stick as well as the code :).

@zuckschwerdt zuckschwerdt merged commit bdd7933 into merbanan:master Aug 3, 2023
andrewjw pushed a commit to andrewjw/rtl_433 that referenced this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants