Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not distribute tests #269

Open
spt29 opened this issue Nov 7, 2024 · 3 comments · May be fixed by #272
Open

Do not distribute tests #269

spt29 opened this issue Nov 7, 2024 · 3 comments · May be fixed by #272
Assignees

Comments

@spt29
Copy link

spt29 commented Nov 7, 2024

The wheel built for this project contains a tests package, which should definitely not be distributed: Its name is very generic, clashes easily with other (local) packages of the same name, leading to obscure and hard-to-find bugs. This is probably just an oversight and easily fixed in setup.py by using

packages=find_packages(exclude=["tests"]),

instead of

packages=find_packages(),
@TKIPisalegacycipher
Copy link
Collaborator

Hi @spt29 thanks for reporting this. If you like, please submit a PR that resolves this issue and I'd be happy to review and mainline it.

svenpanne added a commit to svenpanne/dashboard-api-python that referenced this issue Nov 14, 2024
@svenpanne svenpanne linked a pull request Nov 14, 2024 that will close this issue
@spt29
Copy link
Author

spt29 commented Nov 14, 2024

Done (with my personal account)

@spt29
Copy link
Author

spt29 commented Nov 26, 2024

Anything I can do to get the linked PR landed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants