Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator does not add the required query parameters to methods if the query parameters are arrays of objects #253

Open
HamedOsama opened this issue Apr 24, 2024 · 2 comments

Comments

@HamedOsama
Copy link

Python version installed
3.12.1

Meraki library version installed
1.45.0

OS Platform
Windows 10

Describe the bug
Ranges query parameter is missing in getOrganizationCameraBoundariesLinesByDevice it must have ranges query parameter which required in this endpoint /organizations/{organizationId}/camera/detections/history/byBoundary/byInterval

Code snippets
code-snippet

console-error

But it's working on adding ranges query parameter through postman
working-one

@TKIPisalegacycipher
Copy link
Collaborator

Hi @HamedOsama and thank you for this contribution.

I checked the operation docs and it seems the query params are correctly marked as required, however, the generator for the library does not seem to generate the necessary array of objects query parameters. Therefore, there is a bug in the generator, and not with this specific method.

The library is dynamically generated and thus all changes need to start with either the OAS (which is not the issue here) or the generator. If we were to merge this PR, it'd be lost in the next release of the library. So I will close the PR, but keep this issue open.

So, thanks again for this contribution, but if you'd like to see this fixed permanently, please consider submitting a PR to update the generator so that the generator correctly adds the required query params. Aside from generate_library.py, the jinja templates may also need updates.

In the meantime, we'll track this issue here.

@TKIPisalegacycipher TKIPisalegacycipher changed the title Ranges query parameter is missing in getOrganizationCameraBoundariesLinesByDevice Generator does not add the required query parameters to methods if the query parameters are arrays of objects Apr 24, 2024
@TKIPisalegacycipher
Copy link
Collaborator

Hi @HamedOsama I'm curious if you had a moment to look at a change to the generator that could fix this. No obligation, of course, but I'd be happy to have the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants