Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbolic-taylor-series can't take perturbations as arguments #168

Open
sritchie opened this issue Apr 22, 2024 · 0 comments
Open

symbolic-taylor-series can't take perturbations as arguments #168

sritchie opened this issue Apr 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@sritchie
Copy link
Member

sritchie commented Apr 22, 2024

For example:

((D (fn [x] (first (symbolic-taylor-series exp x)))) 10)
;;=> 0

What's happening:

  • x is getting substituted for a symbol, say x0
  • this is replacing the Dual, not doing the substitition inside of the primal
  • so (exp x0) pops out, and the literal implementation doesn't recurse into its lists, because in NORMAL generic arithmetic without the subs, (exp <dual>) would return type dual, not type literal

So we can fix typical-object here or do something in the function body...

@sritchie sritchie added the bug Something isn't working label Apr 22, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2024
@sritchie sritchie reopened this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant