Leaf Temp Offset between 0-2 has no effect

[faBoulitt]

Checklist

• I updated the card to the latest version available
• I cleared the cache of my browser

Describe the bug
I am using a ambient temperature sensor and a Hygrometer, the value for the leaf temperature is not measured. So I put nothing into the field for the leaf temperature sensor.
Setting the value of the leaf temperature offset to a value between 0 - 2 has no effect on the VPD value.
When using values >2.0 it changes the VPD.

Version of the card
Version: v1.5.0

To Reproduce
This is the configuration I used:

type: custom:ha-vpd-chart
sensors:
  - humidity: sensor.t_h_sensor_humidity
    name: VPD Leaf
    temperature: sensor.t_h_sensor_temperature
vpd_phases:
  - upper: 0
    className: gray-danger-zone
    color: '#999999'
  - lower: 0
    upper: 0.4
    className: under-transpiration
    color: '#1a6c9c'
  - lower: 0.4
    upper: 0.8
    className: early-veg
    color: '#22ab9c'
  - lower: 0.8
    upper: 1.2
    className: late-veg
    color: '#9cc55b'
  - lower: 1.2
    upper: 1.6
    className: mid-late-flower
    color: '#e7c12b'
  - lower: 1.6
    className: danger-zone
    color: '#ce4234'
is_bar_view: false
max_temperature: 30
min_height: 200
enable_tooltip: true
air_text: Air
rh_text: RH
kpa_text: kPa
enable_axes: true
enable_ghostclick: true
enable_ghostmap: true
enable_triangle: true
enable_crosshair: true
enable_fahrenheit: false
enable_zoom: true
enable_show_always_informations: true
enable_legend: false
ghostmap_hours: 24
unit_temperature: °C
min_temperature: 15
min_humidity: 30
max_humidity: 70
leaf_temperature_offset: 0

Expected behavior
VPD is rising when rising the leaf temperature offset value from 0 to 2.

Desktop (please complete the following information):
Home Assistant OS
Core
2024.5.5
Supervisor
2024.09.1
Operating System
13.1
Frontend
20240501.1

[lmnx]

I noticed the same behavior but never bothered since I've switched back to the other HA VPD Card until this issue and Issue 18 is fixed.

Anyhow, the plugin is hardcoded to default offset value to 2 if it's <2. This is the code line.

@mentalilll do you mind having a look? My apology if this is an unwelcomed ping.

[microfx]

has no effect at all here … seems like only the wrong Air temperature is displayed since my template sensor with a VPD formula has the same VPD value as shown

[NoXPhasma]

@microfx

There are 3 parts in the file, that need to be uncommented, to make it work:

ha-vpd-chart/dist/methods.js

Lines 101 to 103 in 9074afd

	if (this.config.leaf_temperature_offset < 2) {
	return 2;
	}

ha-vpd-chart/dist/methods.js

Lines 109 to 111 in 9074afd

	if (offset < 2) {
	return 2;
	}

ha-vpd-chart/dist/methods.js

Lines 115 to 117 in 9074afd

	if (offset < 2) {
	offset = 2;
	}

Here's a patch.

Then create a new cached version of the file:

sudo gzip -fk methods.js

Finally restart HA.

[microfx]

Thanks, but somehow it's not really working. The offset is now -0.5°C or something. Maybe my yaml is broken as well.. no idea.

…

On Nov 19, 2024, at 00:54, NoXPhasma ***@***.***> wrote: @microfx <https://github.com/microfx> There are 3 parts in the file, that need to be uncommented, to make it work: https://github.com/mentalilll/ha-vpd-chart/blob/9074afdecf926d73c8e5246ecb5a572d283744c5/dist/methods.js#L101-L103 https://github.com/mentalilll/ha-vpd-chart/blob/9074afdecf926d73c8e5246ecb5a572d283744c5/dist/methods.js#L109-L111 https://github.com/mentalilll/ha-vpd-chart/blob/9074afdecf926d73c8e5246ecb5a572d283744c5/dist/methods.js#L115-L117 Here's a patch <https://gist.github.com/NoXPhasma/e91d9c17e7d42c495da7f7feb41eb490>. Then create a new cached version of the file: sudo gzip -fk methods.js Finally restart HA. — Reply to this email directly, view it on GitHub <#19 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJB2HDDIYYZSWEYVINPLFGL2BJ42DAVCNFSM6AAAAABPOW4QYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBUGQYTENJWHA>. You are receiving this because you were mentioned.

[NoXPhasma]

The change above does not change the value you set. It only comments out if statements, that would force it to be 2.

[microfx]

oh, that wasn't my problem... I'd be happy if it was 2 - right now it's something else

[mentalilll]

Sorry for the late response :P
microfx is right, there are

currently it's more or less only change the values on the tooltip. thats not a good way to handle that.
i try to figure out what would be the best and do we really need a switch to handle that.

but i have no time to fix that right now. I try to fix it within christmas holidays :P