Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude ListView search elements from auto-close #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cwesdorp
Copy link

When a ListView search is added in combination with auto-close it's not possible to search as this will close the dialog. disable auto-close results in popup that is still open after clicking on a row. This change excluded items in the search section from closing the dialog.

@WillemUXMendix
Copy link
Contributor

Hi cwesdorp.

Could you shed some more light on your listview search elements usecase? Did you place a complete listview with a searchfield into the dropdown? Where does the popup come from? Creating too specific use cases in the default dropdowndivconverter is not the intention of the widget.

I am not fully convinced that your problem cannot be solved in another manner. The dropdowndivconverters standard edition is not meant for exotic usecases. Especially since there is no easy way to test your new functionality of ignoring listviews causing problems in other use cases.

I suggest you keep this version for your specific usecase as I'm sure it works well for you, but unfortunately I do not think it is wise to merge the issue.

@cwesdorp
Copy link
Author

cwesdorp commented Apr 19, 2018 via email

@HunterKoppen
Copy link

Im very happy i checked here, this was exactly what i was looking for. I also had the problem that the dropdown would close if i clicked on the search bar, which made it impossible to search. It would be a good addition in my opinion to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants