Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL 1.1.1 was EOL 11 sep 2023 #60

Open
magnusart opened this issue Oct 14, 2024 · 4 comments
Open

OpenSSL 1.1.1 was EOL 11 sep 2023 #60

magnusart opened this issue Oct 14, 2024 · 4 comments

Comments

@magnusart
Copy link

rsmgclient relies on OpenSSL 1.1.1 which was end of life 11 sep 2023. Perhaps it is time to depend on OpenSSL 3.0, the current LTS?

@gitbuda
Copy link
Member

gitbuda commented Oct 15, 2024

The OpenSSL dependency is there because mgclient depends on it (underlying Bolt protocol client implementation), but it should also work with OpenSSL 3.0 (compiled on Mac M1 with OpenSSL 3.3.1).

What operating system are you compiling and using the client on?

It should be possible to inject the right OpenSSL dependency under https://github.com/memgraph/rsmgclient/blob/master/build.rs, e.g. on Windows OPENSSL_LIB_DIR can be set to get link the right version. 👀 Feel free adjust the build.rs if it doesn't work in your case and submit the PR 🙏

@magnusart
Copy link
Author

magnusart commented Oct 26, 2024

I'm on Mac M1 as well and at the lines referenced below it seems to me like the path to OpenSSL 1.1 is hardcoded, at least when using Homebrew? I haven't considered Windows, as I'm on a different OS, which was not made clear above. Sorry for that.

https://github.com/memgraph/rsmgclient/blob/master/build.rs#L95C9-L99C11

@gitbuda
Copy link
Member

gitbuda commented Oct 26, 2024

You're right, on Mac paths are/were hardcoded 🙈

The following https://github.com/memgraph/rsmgclient/pull/61/files should be an improvement -> could you verify that it works for you?

Offtopic, what's your use-case to use the graph database driver in Rust?

@magnusart
Copy link
Author

"Offtopic, what's your use-case to use the graph database driver in Rust?"
I'm developing in rust, not sure what you mean. Could you be more specific?
Ie do you mean instead of some other driver?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants