Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is not null to query builder #302

Closed
wants to merge 7 commits into from
Closed

Add is not null to query builder #302

wants to merge 7 commits into from

Conversation

imilinovic
Copy link
Contributor

@imilinovic imilinovic commented Feb 15, 2024 •
edited
Loading

Description

Add IS NOT to query builder.

Pull request type

Please delete options that are not relevant.

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring with functional or API changes
  • Refactoring without functional or API changes
  • Build or packaging related changes
  • Documentation content changes
  • Other (please describe):

Related issues

closes #293

Delete section if this PR doesn't resolve any issues.

Closes (link to issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on gqlalchemy/docs

######################################

@imilinovic imilinovic added the feature feature label Feb 15, 2024
@imilinovic imilinovic self-assigned this Feb 15, 2024
@imilinovic imilinovic added the Docs needed Docs needed label Feb 15, 2024
@katarinasupe katarinasupe added this to the v1.6.0 milestone Jun 5, 2024
@katarinasupe katarinasupe linked an issue Jun 5, 2024 that may be closed by this pull request
Add IS NOT NULL to query builder #293
Open
@katarinasupe
Copy link
Contributor

katarinasupe commented Jun 24, 2024 •
edited
Loading

@imilinovic We no longer use the develop branch for the release; everything goes directly to the main.
Why are there 96 changes? It's hard to review.

FYI, as discussed, this will be included in the next release (July 10th). Work on Memgraph is a priority, so we can move the milestone due date if you can't make it.

@imilinovic imilinovic changed the base branch from develop to main July 1, 2024 06:24
@imilinovic imilinovic marked this pull request as ready for review July 1, 2024 06:28
antepusic
antepusic approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

katarinasupe
katarinasupe approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@katarinasupe katarinasupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine. As soon as deda fixes the workflow, the tests should pass as well.

@katarinasupe
Copy link
Contributor

@imilinovic merge the latest main for tests to pass.
Once the tests pass, feel free to squash and merge.

@katarinasupe katarinasupe removed a link to an issue Jul 9, 2024
Add IS NOT NULL to query builder #293
Open
@katarinasupe katarinasupe removed this from the v1.6.0 milestone Jul 9, 2024
@katarinasupe
Copy link
Contributor

I extended the description in #293 which better explains what needs to be done. I am closing this PR since it is not fixing that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katarinasupe katarinasupe katarinasupe approved these changes

@antepusic antepusic antepusic approved these changes

@Josipmrden Josipmrden Awaiting requested review from Josipmrden Josipmrden is a code owner

@as51340 as51340 Awaiting requested review from as51340 as51340 is a code owner

Assignees

@imilinovic imilinovic

Labels
Docs needed Docs needed feature feature
Projects
community bugs and incremental features
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add IS NOT NULL to query builder
3 participants
@imilinovic @katarinasupe @antepusic