Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As an user, I want to start writting a name of an exhibition and see it, so I don't need to find it in a long drop-down menu. #261

Open
hvalois opened this issue Oct 25, 2019 · 6 comments · May be fixed by #454
Open

As an user, I want to start writting a name of an exhibition and see it, so I don't need to find it in a long drop-down menu. #261

hvalois opened this issue Oct 25, 2019 · 6 comments · May be fixed by #454
Assignees
@luccaepp
Labels
AR viewer enhancement New feature or request user
Milestone
Launch

Comments

@hvalois
Copy link
Collaborator

hvalois commented Oct 25, 2019 •
edited
Loading

I've stumbled upon this code a few days ago. I think it would be amazing on the exhibition list, on ARViewer launch.

Unfortunatelly, I don´t know feel confident enough to change the results from a dropdown to a element list by myself. I´m sure this code is very ferocious and could bite off my hands if I try. Anyway, I leave the link here so we can look at this togheter some day.

https://www.w3schools.com/howto/howto_js_filter_table.asp
@pablodiegoss
Copy link
Member

Nice example, we can substitute "name" and "country" for something like "Exhibit Name" and "Exhibit URL". Should be clear enough to use

@vjpixel
Copy link
Member

vjpixel commented Oct 30, 2019

Would be really amazing to have this! The list is getting very long now.

I think that we can have just the name, as we have now, to make it simpler.

@vjpixel vjpixel added this to the Launch milestone Jan 3, 2020
@vjpixel vjpixel added CMS enhancement New feature or request AR viewer user and removed CMS labels Jan 24, 2020
@vjpixel vjpixel changed the title filter exhibition results As an user, I want to start writting a name of an exhibition and see it, so I don't need to find it in a long drop-down menu. Jan 26, 2020
@luccaepp luccaepp self-assigned this Jan 27, 2020
@vjpixel vjpixel added the S label Jan 27, 2020
@hockpond hockpond mentioned this issue Feb 13, 2020
Merged
@hockpond
Copy link
Contributor

Please, review @vjpixel

@vjpixel
Copy link
Member

vjpixel commented Feb 13, 2020

Hey, I think you marked the wrong issue. the PR seems to be related to issue #161

vjpixel added a commit that referenced this issue Feb 14, 2020
@vjpixel
Merge pull request #312 from memeLab/#261
5e7c4a2 
Let the user set a name to markers and objects when creating them. Also, show marker, object and artwork's names when clicking on it
@devsalula devsalula mentioned this issue Oct 14, 2020
Merged
2 tasks
@pablodiegoss pablodiegoss removed the S label Feb 14, 2021
@vjpixel
Copy link
Member

vjpixel commented Jul 10, 2021

I just tested and it seems different than it is on the screenshot in #340 :
Kazam_screenshot_00001

@vjpixel vjpixel reopened this Jul 10, 2021
@vjpixel
Copy link
Member

vjpixel commented Jul 10, 2021

The way it's working now is still confusing for the user.

As I test, I was tried to use the search to open the "casadoscontos" Exhibition and the search didn't show it as an option.

Kazam_screencast_00001.mp4

(For some reason, the screen recorder didn't record the drop-down menu. But it was showing to me.)

The behaviour I propose is that, when the user starts typing, the drop-down opens only showing the filtered list of Exhibitions that matches what's being written.

@KiSobral KiSobral linked a pull request Mar 24, 2022 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luccaepp luccaepp

Labels
AR viewer enhancement New feature or request user
Projects
None yet
Milestone
Launch
Development

Successfully merging a pull request may close this issue.

[REVIEW] 261 - Improve dropdown menu exhibition FGA-GCES/Jandig
5 participants
@vjpixel @hvalois @pablodiegoss @luccaepp @hockpond