<groovy/> sets empty Response in the Response flow, when exc.getResponse() == null

[rrayst]

This leads to

            <groovy>
                println exc.getRequest().getUri()
            </groovy>

producing weird 200 OK responses in error cases.

(This is due to:

api-gateway/core/src/main/java/com/predic8/membrane/core/interceptor/AbstractInterceptor.java

Line 136 in 3e20594

exc.setResponse(response);

)

[predic8]

@t-burch Test and post how the wired response looks like (test with curl).

I do not know if we should change something. Cause this might not the only Interceptor. Maybe we should check in the Transport if response==null and then provide an error message?

[t-burch]

In what circumstance does it set the 200 OK response, how can one reproduce that

[predic8]

Remove setting 200 OK

[predic8]

@rrayst I cannot reproduce the error and I can't find anything in GroovyInterceptor that could lead to this behaviour.

[predic8]

No it returns:

< HTTP/1.1 500 Internal Server Error
< Content-Length: 296
< Content-Type: application/problem+json
<
{
  "message" : null,
  "source" : "throw new RuntimeException()",
  "note" : "To hide error details set Membrane into production mode. In proxies.xml use <router production=\"true\">..</router>.\");\n",
  "type" : "https://membrane-api.io/error/internal",
  "title" : "Error executing script."
* Connection #0 to host localhost left intact
}

[rrayst]

<spring:beans xmlns:spring="http://www.springframework.org/schema/beans"
              xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
              xmlns="http://membrane-soa.org/proxies/1/"
              xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-4.2.xsd
					    http://membrane-soa.org/proxies/1/ http://membrane-soa.org/schemas/proxies-1.xsd">

    <spring:bean id="demoError" class="com.predic8.membrane.core.interceptor.RegExReplaceInterceptor" />

    <router>

        <api port="2000">
            <groovy>
                println exc.getRequest().getUri()
            </groovy>
            <spring:ref bean="demoError" />
            <target host="api.predic8.de" />
        </api>

    </router>

</spring:beans>

(Use any interceptor producing an uncaught Exception after groovy - here: a RegExReplaceInterceptor which has not all properties set.)

http://localhost:2000/ returns "200 OK".