Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application vs Library for SDK-based packages #276

Closed
MeltyBot opened this issue Nov 23, 2021 · 4 comments
Closed

Application vs Library for SDK-based packages #276

MeltyBot opened this issue Nov 23, 2021 · 4 comments
Labels
Accepting Pull Requests discussion Documentation Improvements or additions to documentation flow::triage kind/Feature New feature or request migrated from gitlab valuestream/SDK

Comments

@MeltyBot
Copy link
Contributor

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/278

Originally created by @edgarrmondragon on 2021-11-23 18:03:35

I want to start the conversation around our (recommended) packaging strategy for SDK-based taps and targets.

A recent conversation in Slack revealed that installing SDK-based taps (e.g. pipx install git+https://github.com/MeltanoLabs/tap-github.git) references the specified dependency versions in pyproject.toml and completely ignores the pinned versions in poetry.lock.

The most relevant discussions around using Poetry to distribute end-user Python applications (like Singer Taps) is happening here and in this PR.
@MeltyBot
Copy link
Contributor Author

View 6 previous comments from the original issue on GitLab

@labelsync-manager labelsync-manager bot added the kind/Feature New feature or request label Jun 23, 2022
@stale
Copy link

stale bot commented Jul 18, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 18, 2023
@edgarrmondragon
Copy link
Collaborator

Still relevant. It's probably worth recommending in the connector developer docs to pin minor versions for tap and target dependencies.

@stale stale bot removed the stale label Jul 18, 2023
@edgarrmondragon edgarrmondragon added Documentation Improvements or additions to documentation Accepting Pull Requests labels Jul 18, 2023
@edgarrmondragon
Copy link
Collaborator

Recently @WillDaSilva pointed me to https://github.com/spoorn/poeblix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting Pull Requests discussion Documentation Improvements or additions to documentation flow::triage kind/Feature New feature or request migrated from gitlab valuestream/SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tayloramurphy @edgarrmondragon @MeltyBot