Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Max Records Limit #2312

Open
visch opened this issue Mar 13, 2024 · 0 comments
Open

feat: Add Max Records Limit #2312

visch opened this issue Mar 13, 2024 · 0 comments
Labels
kind/Feature New feature or request valuestream/SDK

Comments

@visch
Copy link
Contributor

visch commented Mar 13, 2024

Feature scope

Taps (catalog, state, stream maps, tests, etc.)

Description

Sometimes we don't want to query more than x number of records for every query. MeltanoLabs/tap-postgres#24 (comment) had an issue where they were getting timeouts to their postgres connection when trying to pull their table over. I assume this is because the table is very large and the initial sync is too big to complete in the timeout window. This can be useful for folks, although it shouldn't be something folks jump to right away to use to fix issues as it could cause other issues (especially if #18 gets implemented)

Example implementation MeltanoLabs/tap-postgres#393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Feature New feature or request valuestream/SDK
Projects
None yet
Development

No branches or pull requests

1 participant