-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy vLatest to production #72
base: main
Are you sure you want to change the base?
Conversation
@@ -54,7 +54,10 @@ | |||
"lint": "npx eslint --color --cache .", | |||
"start": "node dist/index.js", | |||
"dev": "tsc-watch --onSuccess \"node dist/index.js\"", | |||
"publish": "node scripts/publish.js" | |||
"publish": "node scripts/publish.js", | |||
"deploy-ke": "cd scripts/deploy && helm upgrade --kube-context arn:aws:eks:eu-west-2:720541322708:cluster/prod-cht-eks --namespace users-chis-prod --values values/users-chis-ke.yaml users-chis-ke medic/cht-user-management", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this will work as expected, wouldn't this require having medic/cht-user-management
in the deploy directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth replacing these vars with environment variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think when you run these steps then the medic/cht-user-management
is an alias. I tested these commands and I don't have that repo in this folder.
We can do environment variables, but I think just you and I are using this for the foreseeable future and then we are going to move to MoH self-host. Did you try it? Can you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not try it, i followed the steps in https://github.com/medic/cht-user-management/blob/main/scripts/deploy/medic-deploy.md. If it works then no prob we can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just leave it open. Can you try it next time you're doing a deployment? No rush on this one.
* fix(#199): moh civ user management tool issues (#200) * fix(#199): remove duplicate first name fix medic/config-moh-civ#200 * fix(#199): remove required country area in phone fix medic/config-moh-civ#200 * fix(#199): add grand parent level on the hierarchy fix medic/config-moh-civ#200 * fix(#199): add supervision level on the hierarchy (cherry picked from commit 0c6060f) * Add hint to contact properties (#201) (cherry picked from commit 59b5a2d) * fix(#203): update civ config (#204) * feat(#158): integration of user management tool into civ project (#164) --------- Co-authored-by: Alassane Ndoye <[email protected]> Co-authored-by: paulpascal <[email protected]>
No description provided.