error if user tries to create a place with the defined dedup property in use #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddieptf
force-pushed
the
181_duplicates
branch
from
691eebc to
c718599
Compare
freddieptf
changed the title
kennsippell
reviewed
Nov 6, 2024
| @@ -48,6 +48,7 @@ Property | Type | Description | |||
| `contact_types.contact_properties` | Array<ConfigProperty> | Defines the attributes which are collected and set on the user's primary contact doc. See [ConfigProperty](#ConfigProperty). | |||
| `contact_types.deactivate_users_on_replace` | boolean | Controls what should happen to the defunct contact and user documents when a user is replaced. When `false`, the contact and user account will be deleted. When `true`, the contact will be unaltered and the user account will be assigned the role `deactivated`. This allows for account restoration. | |||
| `contact_types.hint` | string | Provide a brief hint or description to clarify the expected input for the property. | |||
| `contact_types.dedup_property` | string | The place's `property_name` used to prevent creation of duplicates under a certain parent. | |||
There was a problem hiding this comment.
This PR which introduced a warning system also proposed a config schema which enforced uniqueness (or "dedupes").
I still would love to get that merged some day. It was derailed by becba25 and I never did the work to update it.
This seems like a partial implementation of features within that PR. It sure would be great to use something like the same config schema so that PR can eventually make it in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181
This adds a way to prevent a user from creating duplicate places by defining a
dedup_propertyon a place. Thededup_propertyis not globally unique but it is scoped to the parent place.