Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add culling to GH backup CI of superset dashboards #173

Open
mrjones-plip opened this issue Oct 24, 2024 · 2 comments
Open

Add culling to GH backup CI of superset dashboards #173

mrjones-plip opened this issue Oct 24, 2024 · 2 comments
Labels
Priority: 3 - Low Can be bumped from the release Type: Improvement Make something better

Comments

@mrjones-plip
Copy link
Contributor

What feature do you want to improve?
We offer a way to to automate backup of superset dashboards. however, the CI job we run will fill up with a backup every day. While handy - this is likely too many files which will never get used.

Describe the improvement you'd like
The CI job should not only make a backup, but also cull older backups from the GH repo. Something like keeping 1/day x 7 days, 1/week x 4 weeks, 1/month x 12 months.

Describe alternatives you've considered
manually cull or do nothing at all

Additional context
we're hoping to have national deployments run this and a more clean list of files in backup dir will be much easier when it comes time to restore.

@mrjones-plip mrjones-plip added the Type: Improvement Make something better label Oct 24, 2024
@dianabarsan
Copy link
Member

dianabarsan commented Oct 29, 2024

@mrjones-plip the CI job can be setup to run on whatever schedule maintainers decide, it doesn't have to be daily. I think automatic deletions are quite dangerous. Manually cull is ok, but that should only require documentation.

@andrablaj andrablaj added the Priority: 3 - Low Can be bumped from the release label Oct 29, 2024
@mrjones-plip
Copy link
Contributor Author

Fair point! While think that the old adage "backup is only as good as the restore" is very applicable here, I can agree that some docs on how to cull older backups would suffice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 3 - Low Can be bumped from the release Type: Improvement Make something better
Projects
None yet
Development

No branches or pull requests

3 participants