You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function safeNum used to check a number from environment variables does not prevent the process to start if the value is invalid, .e.g. passing '25x' return a NaN value, that depending of how the variable is used later, may cause the process to fail, or just to behave as if the value is undefined.
We should change that and make the process to fail, or at least to WARN in the logs about the value.
The text was updated successfully, but these errors were encountered:
Upon testing again I can confirm that if I pass a string it is picking default value of 50 instead of NaN .I believe this is not expected? Can we get this fixed...
The function safeNum used to check a number from environment variables does not prevent the process to start if the value is invalid, .e.g. passing
'25x'
return aNaN
value, that depending of how the variable is used later, may cause the process to fail, or just to behave as if the value isundefined
.We should change that and make the process to fail, or at least to WARN in the logs about the value.
The text was updated successfully, but these errors were encountered: