Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safeNum should warn that the value passed is invalid #107

Open
mrsarm opened this issue Sep 16, 2021 · 1 comment
Open

safeNum should warn that the value passed is invalid #107

mrsarm opened this issue Sep 16, 2021 · 1 comment
Labels
bug help wanted Priority: 3 - Low Can be bumped from the release

Comments

@mrsarm
Copy link
Contributor

mrsarm commented Sep 16, 2021

The function safeNum used to check a number from environment variables does not prevent the process to start if the value is invalid, .e.g. passing '25x' return a NaN value, that depending of how the variable is used later, may cause the process to fail, or just to behave as if the value is undefined.

We should change that and make the process to fail, or at least to WARN in the logs about the value.

@meghna-khemka
Copy link

meghna-khemka commented Sep 16, 2021

Upon testing again I can confirm that if I pass a string it is picking default value of 50 instead of NaN .I believe this is not expected? Can we get this fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted Priority: 3 - Low Can be bumped from the release
Projects
None yet
Development

No branches or pull requests

2 participants