Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "mode" option to FileSystemAccessFileHandle's createSyncAccessHandle and createWritable #479

Open
1 of 5 tasks
nathanmemmott opened this issue Nov 14, 2023 · 9 comments · Fixed by mdn/content#35334
Assignees
Labels
Content: Web API proposal Auto label for new proposals added via the suggestion form

Comments

@nathanmemmott
Copy link

nathanmemmott commented Nov 14, 2023

Proposal

As part of the New Locking Scheme to Enable Multiple Readers and Writers, a new "mode" option is added to both FileSystemAccessFileHandle's createSyncAccessHandle and createWritable functions.

Browser support

Chrome

Tasks

  • createSyncAccessHandle() method
    • Add "options" (FileSystemCreateSyncAccessHandleOptions dictionary) to Parameters
    • Describe the "mode" property, it's possible values ("readwrite", "readonly", "readwrite-unsafe"), and its default value ("readwrite").
  • createWritable() method
    • Add the "mode" property to "options".
    • Describe it, its possible values ("siloed", "exclusive"), and its default value ("siloed").

Dependencies

Additional information

No response

Are you willing to support this work?

Can support with reviews and feedback.

@nathanmemmott nathanmemmott added needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. proposal Auto label for new proposals added via the suggestion form labels Nov 14, 2023
@Rumyra
Copy link
Contributor

Rumyra commented Nov 16, 2023

@chrisdavidmills are you handling this? If so let me know otherwise I'll add to our team tasks

@chrisdavidmills
Copy link
Contributor

chrisdavidmills commented Nov 17, 2023

@Rumyra I'm happy to do this; I'll add it to my worklist.

Proposal makes sense and looks pretty solid; ideally we should wait until it's actually in the spec before documenting. I'll keep an eye on whatwg/fs#151 for progress on this.

@zfox23 zfox23 added Content: Web API and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Dec 5, 2023
@nathanmemmott
Copy link
Author

The feature will be shipped in Chrome stable on Tue, Jan 23, 2024.

@chrisdavidmills
Copy link
Contributor

@nathanmemmott I've added docs to cover these features: mdn/content#35334. Would you be able to provide me with a tech review of this work, or is there someone more appropriate to ask?

Also pinging @tomayac as I know he is heavily involved with APIs around this area.

@tomayac
Copy link

tomayac commented Aug 6, 2024

Reviewed this PR. Thanks for working on it!

@nathanmemmott
Copy link
Author

Left a few comments on the PR. Looks good!

@chrisdavidmills
Copy link
Contributor

Great stuff, thanks @tomayac and @nathanmemmott!

@chrisdavidmills
Copy link
Contributor

Ooop, this was fixed by mdn/content#35334

@chrisdavidmills
Copy link
Contributor

@Rumyra can you close it for me? I don't have the privs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Web API proposal Auto label for new proposals added via the suggestion form
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

5 participants