add missing minlength to np.bincount #260
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This merge request fixes a missing
minlength
argument in two calls tonp.bincount
Details
Currently, the
distance_to_ridge
method will sometimes fail unexpectedly with an IndexError. For example, here's an error trace I receive when attempting to run the method in northern Colorado:This issue occurs when there are NoData values along the bottom edge of the flow direction raster. Essentially, the maximum value in the
endnodes
array is less than the size of the fdir array, and so the subsequent call tonp.bincount
returns an index array with fewer elements than thestartnodes
array.This pull request fixes the bug by adding the
minlength
option tonp.bincount
(as is done elsewhere insgrid.py
) to ensure that the index array always has the correct number of elements.closes #255