Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgtool: sign.py :--confirm parameter is not taken in account if --overwrite-only mode is set #2157

Open
grevaillot opened this issue Dec 20, 2024 · 0 comments

Comments

@grevaillot
Copy link

Generating pre-confirmed binaries does not work if overwrite only mode is selected : option is silently ignored and files are generated.

cf :

if self.confirm and not self.overwrite_only:
& below

Condition was introduced with the initial feature commit - 0ce958e - but, although I understand the initial logic, we're using the confirmation mecanism in overwrite_only configuration to run some validations post upgrade, and need confirmed images for initial flashing.

Maybe some error could be thrown if i overlooked something and that test is mandatory - i scratched my head for a while to understand why freshly flashed images were not confirmed :)

@grevaillot grevaillot changed the title --confirm parameter is not taken in account if --overwrite-only mode is set imgtool: sign.py :--confirm parameter is not taken in account if --overwrite-only mode is set Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant