Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment delete route needs to fill in codeKind, codeOrigin, codeType, codeTypeAndKind #136

Open
brianbolt opened this issue Jan 17, 2018 · 0 comments
Assignees

Comments

@brianbolt
Copy link
Contributor

brianbolt commented Jan 17, 2018

A deep link back to a deleted experiment does not show a status because the codeKind, codeOrigin, codeType and codeTypeAndKind are not filled in when deleting an experiment using the following route:

DELETE on route experiments/browser/"+experimentId

Here is what is should look like:
{
"codeKind": "status",
"codeOrigin": "ACAS DDICT",
"codeType": "experiment",
"codeTypeAndKind": "experiment_status",

"codeValue": "approved",
"deleted": false,
"id": 32,
"ignored": true,
"lsKind": "experiment status",
"lsTransaction": 2,
"lsType": "codeValue",
"lsTypeAndKind": "codeValue_experiment status",
"modifiedDate": 1516213078018,
"operatorTypeAndKind": "null_null",
"publicData": true,
"recordedBy": "administrator",
"recordedDate": 1516211402000,
"unitTypeAndKind": "null_null",
"version": 2
},

Here is what the route currently creates as a status:
{
"codeTypeAndKind": "null_null",
"codeValue": "deleted",
"deleted": false,
"id": 79,
"ignored": false,
"lsKind": "experiment status",
"lsType": "codeValue",
"lsTypeAndKind": "codeValue_experiment status",
"operatorTypeAndKind": "null_null",
"publicData": false,
"recordedBy": "default",
"recordedDate": 1516213528256,
"unitTypeAndKind": "null_null",
"version": 0
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants