Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data persistence issue #20

Closed
LiranPo opened this issue Jun 27, 2024 · 8 comments · Fixed by #32
Closed

Data persistence issue #20

LiranPo opened this issue Jun 27, 2024 · 8 comments · Fixed by #32

Comments

@LiranPo
Copy link

LiranPo commented Jun 27, 2024

I am encountering a recurring issue with the funnel chart, where data seems to "linger" when changing the dashboard's parameters (or when hitting the "refresh" button). Here are the details:

Environment:
Grafana version: 10.4.2
Browser: Chrome and Safari (Issue reproduced in both)

Steps to Reproduce:

  1. Select initial parameters on the dashboard and generate the funnel chart.
  2. Change the parameters to new values.
  3. Observe that the values from the initial run persist and are stacked on the results of the second run (see attached screenshot).

The funnel chart retains (some of the) data from the first run and combines it with data from the second run.
The only way to clear the data and start fresh is to refresh the entire page. Clicking the "refresh dashboard" button does not resolve the issue.

The screenshot below shows for example the "limit_results" step that is stacked over and over again. So much so, that the funnel even covers the visualization below...

Screenshot 2024-06-27 at 19 52 27

@jasonlanderson
Copy link

I'm having this same issue. It seems like it's duplicating or readding steps on panel refresh without clearing the existing data. This happens specifically when I change the dashboard parameters.

@mckn
Copy link
Owner

mckn commented Aug 22, 2024

Thanks for opening this issue! I will try to reproduce this during the day and open a fix prior to the next release.

@jasonlanderson
Copy link

Thanks @mckn, let me know if you need any help!

@mckn
Copy link
Owner

mckn commented Aug 28, 2024

I think it has do to with the generated key for each component which makes it append instead of re-rendering the bar. Trying to verify it aws.

@mckn
Copy link
Owner

mckn commented Aug 28, 2024

@jasonlanderson can you please provide some test information? Can you share anything regarding your dashboard that can help me reproduce this?

@mckn
Copy link
Owner

mckn commented Aug 28, 2024

I think I managed to reproduce it and have a fix in #32

@jasonlanderson
Copy link

Awesome, thanks @mckn! Is there an easy way I can update the funnel plugin in our grafana instance to test it out? We used grafana-cli plugins install mckn-funnel-panel originally to install it.

@LiranPo
Copy link
Author

LiranPo commented Aug 29, 2024

Would also appreciate guidance on how to update.
We use grafana-cli --pluginUrl https://github.com/mckn/mckn-funnel-panel/releases/download/v1.0.0/mckn-funnel-panel-1.0.0.zip plugins install mckn-funnel-panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants