Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to theme selector #656

Open
antonymilne opened this issue Aug 27, 2024 · 0 comments
Open

Minor improvements to theme selector #656

antonymilne opened this issue Aug 27, 2024 · 0 comments
Labels
Nice to have 🍒 Possible projects for a rainy day

Comments

@antonymilne
Copy link
Contributor

Change 1: theme switcher toggle meaning

Currently our theme switcher operates like this:

  • toggled to left = dark theme
  • toggled to right = light theme

We should change it to this:

  • toggled to left = whatever the dashboard creator set as default theme (which is dark by default, but they can override this with Dashboard.theme)
  • toggled to right = the non-default them

@huong-li-nguyen said:

If we implement the suggested change, we'll likely need to adjust our CSS as well. Dan has created different toggle designs for the dark and light themes, which get activated when the toggle is checked. If we change the meaning of "checked," we'll also need to rewrite the CSS accordingly. Currently, I am not sure how easy that is, because the CSS needs to differ on a light theme depending if the light theme was there as a default or if it got switched to it

@petar-qb:

If we decide to implement "default theme on the left side" change, then maybe we don't have to care about what is "checked", but just apply transform: rotateY(180deg); on the toggle button if default theme is "light" (and swap the Sun-Moon positions too).

Change 2: add sun/moon icons

@Joseph-Perkins said:

ultimately I think the theme switching toggle is pending a redesign, because it was chosen more for ease/speed of implementation at the time (ie. a pre-existing component), rather than having been fully designed
eventually it will probably be replaced by something more like a sun/moon based toggle, which makes it immediately understandable what the toggle settings relate to (and the relevant one will be selected by default) - plus it will also probably end up in a "settings" menu (which itself will probably be down at the bottom on the left)

@antonymilne antonymilne added the Nice to have 🍒 Possible projects for a rainy day label Aug 27, 2024
@antonymilne antonymilne removed their assignment Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nice to have 🍒 Possible projects for a rainy day
Projects
None yet
Development

No branches or pull requests

1 participant