You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we implement the suggested change, we'll likely need to adjust our CSS as well. Dan has created different toggle designs for the dark and light themes, which get activated when the toggle is checked. If we change the meaning of "checked," we'll also need to rewrite the CSS accordingly. Currently, I am not sure how easy that is, because the CSS needs to differ on a light theme depending if the light theme was there as a default or if it got switched to it
If we decide to implement "default theme on the left side" change, then maybe we don't have to care about what is "checked", but just apply transform: rotateY(180deg); on the toggle button if default theme is "light" (and swap the Sun-Moon positions too).
ultimately I think the theme switching toggle is pending a redesign, because it was chosen more for ease/speed of implementation at the time (ie. a pre-existing component), rather than having been fully designed
eventually it will probably be replaced by something more like a sun/moon based toggle, which makes it immediately understandable what the toggle settings relate to (and the relevant one will be selected by default) - plus it will also probably end up in a "settings" menu (which itself will probably be down at the bottom on the left)
The text was updated successfully, but these errors were encountered:
Change 1: theme switcher toggle meaning
Currently our theme switcher operates like this:
We should change it to this:
Dashboard.theme
)@huong-li-nguyen said:
@petar-qb:
Change 2: add sun/moon icons
@Joseph-Perkins said:
The text was updated successfully, but these errors were encountered: