From 0a94ebd478ef437ad4e7c25e8e3651f04adba2e8 Mon Sep 17 00:00:00 2001 From: huong-li-nguyen Date: Wed, 7 Aug 2024 12:11:48 +0200 Subject: [PATCH] Remove all pylint ignores --- vizro-ai/src/vizro_ai/_vizro_ai.py | 2 +- vizro-ai/src/vizro_ai/utils/helper.py | 1 - .../actions/_action_loop/test_get_action_loop_components.py | 2 +- vizro-core/tests/unit/vizro/models/_action/test_action.py | 2 +- 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/vizro-ai/src/vizro_ai/_vizro_ai.py b/vizro-ai/src/vizro_ai/_vizro_ai.py index e73a11d5d..0c3362b52 100644 --- a/vizro-ai/src/vizro_ai/_vizro_ai.py +++ b/vizro-ai/src/vizro_ai/_vizro_ai.py @@ -120,7 +120,7 @@ def _get_chart_code(self, df: pd.DataFrame, user_input: str) -> str: # TODO retained for some chat application integration, need deprecation handling return self._run_plot_tasks(df, user_input, explain=False).code - def plot( # pylint: disable=too-many-arguments + def plot( self, df: pd.DataFrame, user_input: str, diff --git a/vizro-ai/src/vizro_ai/utils/helper.py b/vizro-ai/src/vizro_ai/utils/helper.py index 48fe03638..71bf59a9e 100644 --- a/vizro-ai/src/vizro_ai/utils/helper.py +++ b/vizro-ai/src/vizro_ai/utils/helper.py @@ -103,7 +103,6 @@ def _display_markdown(code_snippet: str, biz_insights: str, code_explain: str) - """ try: - # pylint: disable=import-outside-toplevel from IPython.display import Markdown, display except Exception as exc: raise ImportError("Please install IPython before proceeding in jupyter environment.") from exc diff --git a/vizro-core/tests/unit/vizro/actions/_action_loop/test_get_action_loop_components.py b/vizro-core/tests/unit/vizro/actions/_action_loop/test_get_action_loop_components.py index 6f092d3db..f27f38abc 100644 --- a/vizro-core/tests/unit/vizro/actions/_action_loop/test_get_action_loop_components.py +++ b/vizro-core/tests/unit/vizro/actions/_action_loop/test_get_action_loop_components.py @@ -141,7 +141,7 @@ def test_no_components(self): ], indirect=True, ) - def test_all_action_loop_components( # pylint: disable=too-many-arguments + def test_all_action_loop_components( self, fundamental_components, gateway_components, diff --git a/vizro-core/tests/unit/vizro/models/_action/test_action.py b/vizro-core/tests/unit/vizro/models/_action/test_action.py index f42a63542..bc2a0b5e4 100644 --- a/vizro-core/tests/unit/vizro/models/_action/test_action.py +++ b/vizro-core/tests/unit/vizro/models/_action/test_action.py @@ -193,7 +193,7 @@ def test_get_callback_mapping_no_inputs_no_outputs(self, identity_action_functio ), ], ) - def test_get_callback_mapping_with_inputs_and_outputs( # pylint: disable=too-many-arguments + def test_get_callback_mapping_with_inputs_and_outputs( self, inputs_and_outputs, identity_action_function,