Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdateFrequencyWrapper bug #41

Open
JoyMonteiro opened this issue Aug 15, 2018 · 1 comment
Open

UpdateFrequencyWrapper bug #41

JoyMonteiro opened this issue Aug 15, 2018 · 1 comment

Comments

@JoyMonteiro
Copy link
Collaborator

When UFW wraps a TendencyComponent, it should be considered an instance of TendencyComponent. However, sympl currently considers it both a TendencyComponent and ImplicitTendencyComponent, which ends up calling a TendencyComponent with a timestep, causing it to error.
@mcgibbon
Copy link
Owner

I added a fix to UFW that will retry without passing along the timestep if it gets a TypeError, but the underlying problem that UpdateFrequencyWrapper is considered an ImplicitTendencyComponent regardless of whether it wraps one currently remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoyMonteiro @mcgibbon