-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible bug in TendencyStepper #37
Comments
Could you write a MCVE for me to reproduce the error? |
I have fixed the component, but if you comment out the following line: in radiation.py and run the following line: AdamsBashforth([GrayLongwaveRadiation]) I get an error. |
This is not a proper fix, because there is still an underlying bug in TendencyStepper. You shouldn't need to specify dims on a tendency when that quantity is present in the inputs. |
Yes, which is why i brought it to your attention. |
The gray longwave component in climt had a tendency which did not define its dims. Since this property is available in the input_properties of the component, one would imagine that this is ok. However,
since the code for output_properties in TendencyStepper does not pass the input properties to
combine_component_properties
, we get an InvalidPropertyDictError.This is in the line
sympl/sympl/_core/tendencystepper.py
Line 84 in 3277b7b
This occurs when I try to create a timestepper with gray gas radiation alone.
I have fixed the issue by adding a dims property to the component. However, I wanted to check if this is expected behaviour.
The text was updated successfully, but these errors were encountered: