-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New make_gap.py generates only one Hirshfeld alphase #3
Comments
@richardjana, I also found that the local_property value is parsed fully like vdw_v0 = {H:0.6:C:0.8}. I guess it is also because the new script is "one species oriented" for the Hirshfeld part. |
With multiple Hirshfeld descriptors present, I wanted to assign them to their corresponding soap descriptors by comparing the descriptor strings. Should this be possible? E.g., in Rinas example GAP, the Hirshfeld descriptors use nsparse, while the soap use per config type nsparse, so they don't exactly line up ... |
I think you could split the string into fields, making a list, and then remove specific ones which don't need to match (e.g., nsparse, delta, zeta, etc.). You can then make a check that each element in the GAP's list is in the Hirshfeld's list. Or something like that. |
Well, I already have a function that splits a descriptor into a dictionary, so that sounds straight forward. I'd need a comprehensive list of irrelevant fields (or better, of the relevant fields) though. |
By default the new make_gap generates only alphas_hirshfeld.dat. In my case it means, that I get alphas only for C or H. Could you please @richardjana fix it? Previous script was generating the alphas_hirshfel_1.dat and alphas_hirshfeld_2.dat if several species found.
The text was updated successfully, but these errors were encountered: