feat: Android more tab #560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
commented
Nov 27, 2024
| @@ -153,6 +149,10 @@ fun NearbyTransitPage( | |||
| } | |||
|
|
|||
| LaunchedEffect(navRoute) { | |||
| if (navBarVisible) { | |||
There was a problem hiding this comment.
I noticed that when navigating between Nearby Transit & Stop Details, the bottom nav bar would flicker in and out. This seems to resolve the problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: [Android] set up more page
What is this PR for?
Adds basic more tab.
This maintains the structure of NearbyTransitPage and MorePage having separate BottomNavBars.
We could potentially pull the bar up a level as described in the Navigate with Compose tutorial, but we don't always wan the bar to show (NearbyTransitPage manages the logic of hiding the bar for StopDetails, and leaving that within NearbyTransitPage feels appropriate).
Testing
What testing have you done?