Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prop instead of naming layer name within Widget Class #8

Open
jsanch opened this issue Nov 15, 2019 · 0 comments
Open

Use prop instead of naming layer name within Widget Class #8

jsanch opened this issue Nov 15, 2019 · 0 comments

Comments

@jsanch
Copy link

jsanch commented Nov 15, 2019

StyleToggle and Range (maybe there are others) widgets are now naming layer names wihtin the class instead of using the one passed in to the class via prop arguments.

Example of this in StyleToggle:

this.props.layers.railaccidents.style.setContent(this.props.cartocss);

The fix should be to replace this.props.layers.railaccidents.style.setContent(this.props.cartocss) with this.props.layer.style.setContent(this.props.cartocss)

Example of this in Range:

this.props.layers.railaccidents.source.addFilter(filter);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant