Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom out on framegrab when new localization selected in gridview on left (issue is with two or more localization on same framegrab) #64

Open
kwalz opened this issue Dec 11, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request gui Changes to the graphical user interface

Comments

@kwalz
Copy link

kwalz commented Dec 11, 2023

In gridview, when we click on a localization in gridview on left, the framegrab view should zoom out to full frame (upper right). This should hold true for localizations made on the same frame as well. Attached is an example of localization where I am clicked on one, zoomed in in framegrab view then clicked on next localization in that image and gridview did not zoom out on same framegrab.

Screenshot 2023-12-11 at 12 03 09 PM

Hard to type this issue, I can show if needed.

@kevinsbarnard
Copy link
Collaborator

@kwalz, this was changed in v0.4.2 as I had originally (from v0.3.9) set up the autoranging (zooming in/out to fit the full frame) to be applied when a localization is selected, but there was an issue on the VARS-ML-SE-tasks (item 31, "Gridview jumping to full frame unexpectedly.") that indicated this was unexpected behavior:

Gridview preview window snaps to full frame if you click inside the ROI. This is not the action we would expect.

Since v0.4.2, the image view only autoranges when the image changes. Do we want to revert this change?

@kwalz
Copy link
Author

kwalz commented Dec 11, 2023

@kevinsbarnard Hi Kevin, no to revert :) we definitely want it as it was fixed for localizations from different framegrabs. If it's not possible to have it for different ROI gridview selections then let's set this one aside for the new Gridview replacement and we can brainstorm on ways to achieve this. Perhaps we double click on an ROI in gridview on left and that brings the image back to full size in framegrab view.

@kevinsbarnard
Copy link
Collaborator

Roger that, I'll keep that behavior in for now, and I think I could make the double-click work! On that note, I'm wondering: do you think it would be better if the double click zooms to the selected localization in the image view, instead of zooming out to the full frame? Happy to do it either way, but I figure that might help so you wouldn't need to then zoom in to the selected localization after it zooms out to the full frame.

@kevinsbarnard kevinsbarnard self-assigned this Dec 11, 2023
@kevinsbarnard kevinsbarnard added enhancement New feature or request gui Changes to the graphical user interface labels Dec 11, 2023
@kwalz
Copy link
Author

kwalz commented Dec 11, 2023

Kyra and I are discussing, let's talk in the next meeting about how we can optimize. We'll think about how it may work as we are cleaning up things in the lab today and tomorrow.

@lonnylundsten
Copy link

@kwalz @kevinsbarnard This is done, correct?

@kwalz
Copy link
Author

kwalz commented Sep 24, 2024

@lonnylundsten This was tabled for the next version of Gridview as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gui Changes to the graphical user interface
Projects
None yet
Development

No branches or pull requests

3 participants